Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel with CONFIG_IKHEADERS for BPF tools on Kubernetes #8582

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Kernel with CONFIG_IKHEADERS for BPF tools on Kubernetes #8582

merged 1 commit into from
Jun 29, 2020

Conversation

alban
Copy link
Contributor

@alban alban commented Jun 27, 2020

BCC tools need to have access to kernel headers. It can be done either
by installing linux-headers packages or by having a kernel compiled with
CONFIG_IKHEADERS so that enough information can be retrieved via
/sys/kernel/kheaders.tar.xz.

BCC tools are used in Inspektor Gadget, a collection of tools for
developers of Kubernetes applications. I would like Inspektor Gadget to
support Minikube.

Fixes #8556

@alban
kernel config: add CONFIG_IKHEADERS
b2d6962 
BCC tools need to have access to kernel headers. It can be done either
by installing linux-headers packages or by having a kernel compiled with
CONFIG_IKHEADERS so that enough information can be retrieved via
/sys/kernel/kheaders.tar.xz.

BCC tools are used in Inspektor Gadget, a collection of tools for
developers of Kubernetes applications. I would like Inspektor Gadget to
support Minikube.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @alban!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alban. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@alban
Copy link
Contributor Author

alban commented Jun 27, 2020

It seems to work:

$ ./out/minikube start --iso-url=file://$(pwd)/out/minikube.iso
$ ./out/minikube ssh
                         _             _            
            _         _ ( )           ( )           
  ___ ___  (_)  ___  (_)| |/')  _   _ | |_      __  
/' _ ` _ `\| |/' _ `\| || , <  ( ) ( )| '_`\  /'__`\
| ( ) ( ) || || ( ) || || |\`\ | (_) || |_) )(  ___/
(_) (_) (_)(_)(_) (_)(_)(_) (_)`\___/'(_,__/'`\____)

$ uname -a
Linux minikube 5.4.40 #1 SMP Sat Jun 27 15:36:59 UTC 2020 x86_64 GNU/Linux
$ ls -l /sys/kernel/kheaders.tar.xz
-r--r--r-- 1 root root 3438056 Jun 27 16:33 /sys/kernel/kheaders.tar.xz
$

@alban
Copy link
Contributor Author

alban commented Jun 28, 2020

/assign @josedonizetti

@afbjorklund
Copy link
Collaborator

@alban : we don't have any packages on the minikube iso, so this could be a good alternative

3 MB doesn't seem to much to pay (size addition to the iso), for having better BPF compatibility

@rata
Copy link
Member

rata commented Jun 29, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@alban
Copy link
Contributor Author

alban commented Jun 29, 2020

Thanks for the quick review @afbjorklund! I understand we need a /lgtm for a lgtm label (in addition to the github review). Could you lgtm or approve the PR?

@afbjorklund
Copy link
Collaborator

Actually we need a merge and then a new ISO, and we are currently having some issues with it...

@afbjorklund
Copy link
Collaborator

But I think the configuration change looks good, maybe we need to update the docs as well ?

@afbjorklund
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, alban

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4485c5c into kubernetes:master Jun 29, 2020
This was referenced Jun 30, 2020
Closed
Closed
Open
@dalehamel dalehamel mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

@josedonizetti josedonizetti

@afbjorklund afbjorklund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kernel with CONFIG_IKHEADERS for BPF tools on Kubernetes
7 participants
@alban @k8s-ci-robot @minikube-bot @afbjorklund @rata @minikube-pr-bot @josedonizetti